Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --namespace argument to launch command. #433

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add --namespace argument to launch command. #433

wants to merge 1 commit into from

Conversation

StefanFabian
Copy link

@StefanFabian StefanFabian commented Jan 23, 2025 •
edited
Loading

This PR adds support for pushing a namespace when launching a launch file.

fujitatomoya
fujitatomoya approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i would add the test but i do not see any tests for ros2 launch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanFabian @fujitatomoya